Skip to content

Comments

[winrt support] Changes to make Boost System work on the Windows Runtime.#3

Merged
Beman merged 1 commit intoboostorg:developfrom
microsoftarchive:winrt
Jun 4, 2014
Merged

[winrt support] Changes to make Boost System work on the Windows Runtime.#3
Beman merged 1 commit intoboostorg:developfrom
microsoftarchive:winrt

Conversation

@stgates
Copy link
Contributor

@stgates stgates commented May 27, 2014

Basically just use FormatMessageW without FORMAT_MESSAGE_FROM_SYSTEM. Determining whether the Windows Runtime is currently being targeted is done with a Boost Predef.

Basically just use FormatMessageW without FORMAT_MESSAGE_FROM_SYSTEM.
@stgates
Copy link
Contributor Author

stgates commented May 27, 2014

Please note this change depends on an outstanding pull request I have on the Config library to define BOOST_NO_ANSI_APIS.

boostorg/config#16

@Beman
Copy link
Contributor

Beman commented May 27, 2014

Where is the #include <boost/predef/platform.h>? Or am I missing something. (I've not used Boost.Predef before)

Thanks,

--Beman

@Beman
Copy link
Contributor

Beman commented May 27, 2014

Hum.... I guess I should have written <boost/predef/platform.h>

--Beman

@stgates
Copy link
Contributor Author

stgates commented May 27, 2014

It's transitively pulled in from the pull request I referenced in Boost.Config. All that is needed is to include boost/predef.h.

@Beman
Copy link
Contributor

Beman commented May 27, 2014

On Tue, May 27, 2014 at 5:43 PM, stgates notifications@github.com wrote:

It's transitively pulled in from the pull request I referenced in
Boost.Config. All that is needed is to #include .

I just figured that out. By the way, did you mean to reference a file to
include? The markdown on these comments is throwing away anything inside
< ... > - instead you have to write ampersand LT semicolon and
ampersand GT semicolon.

--Beman

@Beman
Copy link
Contributor

Beman commented May 27, 2014

On Tue, May 27, 2014 at 5:49 PM, Beman Dawes bdawes@acm.org wrote:

On Tue, May 27, 2014 at 5:43 PM, stgates notifications@github.com wrote:

It's transitively pulled in from the pull request I referenced in
Boost.Config. All that is needed is to #include .

I just figured that out. By the way, did you mean to reference a file to
include? The markdown on these comments is throwing away anything inside
< ... > - instead you have to write ampersand LT semicolon and
ampersand GT semicolon.

Hummm. It is even worse than that. What happens depends on whether you
respond via email or web interface. So < ... > didn't get converted
to < ... > in the above because I had switched to email.. GRRRR.

--Beman

@stgates
Copy link
Contributor Author

stgates commented May 27, 2014

Yes it got messed up. To be clear here the code as it stands in this pull request will work fine because the boost\predef.h header file is being pulled in transitively from boost\config.hpp.

Once the pull request I have in Boost.Config gets merged this one can as well. Perhaps I could have waited, but I figured send it now and I can address any feedback without have to wait.

Thanks,
Steve

Beman added a commit that referenced this pull request Jun 4, 2014
[winrt support] Changes to make Boost System work on the Windows Runtime.
@Beman Beman merged commit 25e79b3 into boostorg:develop Jun 4, 2014
@stgates stgates deleted the winrt branch June 4, 2014 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants