reformulated SFINAE clauses checking key_type completeness#351
Merged
Conversation
… SFINAE invocations of the latter dependent
key_type completenesskey_type completeness
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #351 +/- ##
========================================
Coverage 98.23% 98.23%
========================================
Files 161 161
Lines 22247 22247
========================================
Hits 21855 21855
Misses 392 392
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emplace(K&& k, V&& v)overloads were SFINAE-protected forkey_typemove constructibility, additionally supplemented with a check forkey_typecompleteness to makeincomplete_tests pass. SFINAEing on type completeness for an incomplete typeTand completingTlater on is IFNDR, and GCC 16 detects this and emits asfinae-incompletewarning.Solved by transforming
key_typemove constructibility check into a dependent construct.