Skip to content

Conversation

@daveoconnor
Copy link
Collaborator

@daveoconnor daveoconnor commented Nov 15, 2025

This PR is related to tickets #2004 and #2005.

The fix for beta version not showing up in version drop down is to have mark_fully_completed run on an import of the beta release, and the fix for beta release notes not being imported is to have mark_fully_completed run before import_release_notes is run.

We should make this less like an OK Go video, either by flattening it out, merging parts together, and/or maybe migrating to an Apache Airflow setup for task orchestration.

https://www.youtube.com/watch?v=GrEskQFqQE0

Testing:

delete the beta versions, run "do it all" or "get release report data", whichever applies, then when it has completed check the beta versions are listed in the libraries page drop down.

@daveoconnor daveoconnor changed the title Beta release issues fixes Beta release issues fixes (#2004, #2005) Nov 15, 2025
Copy link
Collaborator

@gregjkal gregjkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That turned out to be a simple fix! LGTM.

@daveoconnor daveoconnor force-pushed the doc/2004-mark-fully-completed-not-executing branch from e417eec to bcffa47 Compare November 19, 2025 00:06
@karimarie67
Copy link
Collaborator

Deleted beta release and ran Do It All. Once complete beta release was available throughout the admin console. Looks good! @daveoconnor

@daveoconnor
Copy link
Collaborator Author

daveoconnor commented Dec 2, 2025

Was it also available on the libraries/release page dropdowns?

@daveoconnor daveoconnor merged commit 591814f into develop Dec 2, 2025
4 checks passed
@daveoconnor daveoconnor deleted the doc/2004-mark-fully-completed-not-executing branch December 2, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants