Feedback PR for #2287: Story 2269: Enable Conditional S3 Storage for development

[herzog0]

⚠️ Base branch is jc/conditional-image-storage

Feedback for PR #2287

Issue: 2269

Changes

• Renamed the original upload-images.sh script to sync-large-static-images.sh;
• Encapsulated the behavior of the uploads images into a function in the sync script;
• Changed the behavior of the upload function to "up sync", using the same strategy to down sync, i.e., it won't copy all files from SOURCE_DIR to aws every time, it'll just sync the static-large/ folder upwards too, which is totally safe as it won't delete anything in the remote buckets;
  • Therefore I removed the section that offers to delete the source dir after upload;
• Added the "down-sync" capabilities to the script;
• Defaults to uploading to the staging bucket rather than all of them;
• Changed/added the commands in justfile:
  • down_sync_images; → now calls the new script
  • up_sync_images; → defaults to uploading to staging bucket only;
  • up_sync_images_all_buckets: → uploads to all buckets
• Changed the AWS profile from upload-images to sync-boost-images for better comprehension (we may have credentials for multiple projects in our local machines);
• Added documentation in the readme file;

[jlchilders11]

Some thoughts on the implementation, but I do like the basic concept, pending Sam's approval.

[jlchilders11]

LGTM - I like this approach

[julhoang]

LGTM! Just 1 tiny nit for an outdated note