-
Notifications
You must be signed in to change notification settings - Fork 192
docs: Update composefs finalization docs #2168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cgwalters
wants to merge
1
commit into
bootc-dev:main
Choose a base branch
from
cgwalters:composefs-internals
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,55 @@ | ||||||
| # NAME | ||||||
|
|
||||||
| bootc-finalize-staged.service | ||||||
|
|
||||||
| # DESCRIPTION | ||||||
|
|
||||||
| This service finalizes a staged composefs deployment at shutdown, making | ||||||
| it active for the next boot. It is the composefs equivalent of | ||||||
| `ostree-finalize-staged.service`. | ||||||
|
|
||||||
| The service runs as `ExecStop=/usr/bin/bootc composefs-finalize-staged`, | ||||||
| meaning finalization happens during the shutdown/reboot sequence. It is | ||||||
| started when `bootc upgrade` or `bootc switch` stages a new deployment. | ||||||
|
|
||||||
| The finalization process: | ||||||
|
|
||||||
| 1. Reads the staged deployment record from `/run/composefs/staged-deployment` | ||||||
| (a JSON file written during `bootc upgrade`/`switch`). If no staged | ||||||
| deployment exists, the service exits successfully with no action. | ||||||
|
|
||||||
| 2. If the staged deployment is marked download-only (from | ||||||
| `bootc upgrade --download-only`), exits without finalizing. | ||||||
|
|
||||||
| 3. Performs a three-way merge of `/etc`: the pristine `/etc` from the | ||||||
| currently booted EROFS image, the running system's `/etc` (which may | ||||||
| have local modifications), and the new deployment's `/etc`. | ||||||
|
|
||||||
| 4. Atomically swaps the boot loader entries: `loader/entries.staged` is | ||||||
| exchanged with `loader/entries` via a single `RENAME_EXCHANGE` syscall, | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| then the old staged directory is removed. For UKI entries, the `.staged` | ||||||
| suffix is removed from the UKI files on the ESP. | ||||||
|
|
||||||
| After finalization, the next boot uses the new deployment's boot entries. | ||||||
| If finalization fails, the old boot entries remain in place and the system | ||||||
| boots the previous deployment. | ||||||
|
|
||||||
| # DIAGNOSTICS | ||||||
|
|
||||||
| Check the journal for finalization results from the previous boot: | ||||||
|
|
||||||
| ``` | ||||||
| journalctl -u bootc-finalize-staged.service -b -1 | ||||||
| ``` | ||||||
|
|
||||||
| There is not currently a `bootc-boot-complete.service` equivalent (unlike | ||||||
| the ostree backend's `ostree-boot-complete.service`). Monitoring the | ||||||
| journal is the recommended way to detect finalization failures. | ||||||
|
|
||||||
| # SEE ALSO | ||||||
|
|
||||||
| **bootc**(8), **bootc-upgrade**(8), **bootc-switch**(8) | ||||||
|
|
||||||
| # VERSION | ||||||
|
|
||||||
| <!-- VERSION PLACEHOLDER --> | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
NAMEsection in a man page should follow the standard format:name - summary description. This allows tools likeaproposto correctly index the service and provides a quick overview for users.