Skip to content

Conversation

@p5
Copy link
Contributor

@p5 p5 commented Oct 9, 2025

Renovate is not aware of how to version Fedora OCI images, and always attempts to upgrade to pre-release versions (currently 43).

Disable management of all quay.io/fedora/fedora and quay.io/fedora/fedora-bootc.

Renovate is not aware of how to version Fedora OCI images, and
always attempts to upgrade to pre-release versions (currently
43).

Disable management of all quay.io/fedora/fedora and
quay.io/fedora/fedora-bootc.

Signed-off-by: Robert Sturla <robertsturla@outlook.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @p5, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where Renovate was incorrectly attempting to upgrade Fedora OCI images to pre-release versions. By updating the shared Renovate configuration, dependency management for specific Fedora OCI images (quay.io/fedora/fedora and quay.io/fedora/fedora-bootc) is now explicitly disabled across both Dockerfile and GitHub Actions contexts. This change prevents erroneous and disruptive dependency updates, ensuring greater stability in the project's dependency management.

Highlights

  • Renovate Configuration Update: The renovate-shared-config.json file has been modified to prevent Renovate from managing specific Fedora OCI image dependencies.
  • Expanded Scope for Fedora OCI Images: The configuration now explicitly disables dependency management for both quay.io/fedora/fedora and quay.io/fedora/fedora-bootc images.
  • GitHub Actions Integration: The matchManagers list has been updated to include github-actions, ensuring that Renovate's management is disabled for these Fedora OCI images when referenced within GitHub Actions workflows, in addition to Dockerfiles.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to prevent Renovate from managing Fedora OCI images, as it incorrectly tries to upgrade to pre-release versions. The changes correctly add quay.io/fedora/fedora-bootc to the ignore list and also extend the rule to the github-actions manager. The changes are logical and address the issue described. I have one suggestion to make the configuration more concise by using a regular expression.

Comment on lines 74 to 77
"matchDepNames": [
"quay.io/fedora/fedora"
"quay.io/fedora/fedora",
"quay.io/fedora/fedora-bootc"
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For conciseness and better maintainability, you could use matchPackagePatterns with a regular expression to combine the two dependency names into a single pattern. This would also make it easier to add similar Fedora images in the future if needed.

      "matchPackagePatterns": [
        "^quay\\.io/fedora/fedora(-bootc)?$"
      ],

Copy link
Contributor Author

@p5 p5 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While yes, it's more concise, I'd much prefer to maintain a list rather than regex. There's no need to introduce regex to this rule.

Copy link
Contributor

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one could probably use a comment for the record, but not worth respinning.

@cgwalters cgwalters merged commit f775bf5 into bootc-dev:main Oct 9, 2025
1 of 2 checks passed
@p5
Copy link
Contributor Author

p5 commented Oct 9, 2025

This one could probably use a comment for the record, but not worth respinning.

The comment above the snippet is still relevant :)

// Disable Fedora OCI updates
//
// This is due to there not being an easy way to tell Renovate which
// Fedora version is "stable" and which has not been released yet.

@cgwalters
Copy link
Contributor

Right sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants