-
Notifications
You must be signed in to change notification settings - Fork 3
fix: prevent dependency management of Fedora OCI images #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Renovate is not aware of how to version Fedora OCI images, and always attempts to upgrade to pre-release versions (currently 43). Disable management of all quay.io/fedora/fedora and quay.io/fedora/fedora-bootc. Signed-off-by: Robert Sturla <robertsturla@outlook.com>
Summary of ChangesHello @p5, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where Renovate was incorrectly attempting to upgrade Fedora OCI images to pre-release versions. By updating the shared Renovate configuration, dependency management for specific Fedora OCI images ( Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to prevent Renovate from managing Fedora OCI images, as it incorrectly tries to upgrade to pre-release versions. The changes correctly add quay.io/fedora/fedora-bootc to the ignore list and also extend the rule to the github-actions manager. The changes are logical and address the issue described. I have one suggestion to make the configuration more concise by using a regular expression.
| "matchDepNames": [ | ||
| "quay.io/fedora/fedora" | ||
| "quay.io/fedora/fedora", | ||
| "quay.io/fedora/fedora-bootc" | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For conciseness and better maintainability, you could use matchPackagePatterns with a regular expression to combine the two dependency names into a single pattern. This would also make it easier to add similar Fedora images in the future if needed.
"matchPackagePatterns": [
"^quay\\.io/fedora/fedora(-bootc)?$"
],There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While yes, it's more concise, I'd much prefer to maintain a list rather than regex. There's no need to introduce regex to this rule.
cgwalters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one could probably use a comment for the record, but not worth respinning.
The comment above the snippet is still relevant :)
|
|
Right sorry! |
Renovate is not aware of how to version Fedora OCI images, and always attempts to upgrade to pre-release versions (currently 43).
Disable management of all quay.io/fedora/fedora and quay.io/fedora/fedora-bootc.