Skip to content

fix: prevent dependency management of Fedora OCI images #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgwalters merged 1 commit into from
Oct 9, 2025
Merged

fix: prevent dependency management of Fedora OCI images #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions renovate-shared-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,12 @@
"Disable Fedora OCI updates"
],
"matchManagers": [
"dockerfile"
"dockerfile",
"github-actions"
],
"matchDepNames": [
"quay.io/fedora/fedora"
"quay.io/fedora/fedora",
"quay.io/fedora/fedora-bootc"
],
Comment on lines 74 to 77
Copy link

@gemini-code-assist gemini-code-assist bot Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For conciseness and better maintainability, you could use matchPackagePatterns with a regular expression to combine the two dependency names into a single pattern. This would also make it easier to add similar Fedora images in the future if needed.

      "matchPackagePatterns": [
        "^quay\\.io/fedora/fedora(-bootc)?$"
      ],

Copy link
Contributor Author

@p5 p5 Oct 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While yes, it's more concise, I'd much prefer to maintain a list rather than regex. There's no need to introduce regex to this rule.

"enabled": false
}
Expand Down
Loading