snagrecover: improve logging on USB access errors #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foutete
force-pushed
the
usb_access_permission
branch
2 times, most recently
from
4cd9975 to
9f72262
Compare
rgantois
requested changes
Sep 27, 2025
Collaborator
rgantois
left a comment
rgantois
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I've requested a few changes.
Foutete
force-pushed
the
usb_access_permission
branch
from
9f72262 to
74a6591
Compare
Contributor
Author
|
Hi Romain :) ! Finally took some time to work on this PR, tell me if it looks good for you. |
rgantois
requested changes
Nov 10, 2025
Collaborator
rgantois
left a comment
rgantois
left a comment
There was a problem hiding this comment.
Hi François! Thanks for the corrections! There are still a couple of things to straighten out and then we should be good to merge :)
rgantois
reviewed
Nov 10, 2025
When an USB Device can't be accessed, snagrecover prints a generic error message stating to check presence and access right. Improve this by testing if the USB error is a permission error. If so log an error message and some hints on how to solve it. Signed-off-by: François Foltete <francois.foltete@bootlin.com>
Foutete
force-pushed
the
usb_access_permission
branch
from
74a6591 to
649c2e3
Compare
Collaborator
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an USB Device can't be accessed, snagrecover prints a generic error message stating to check presence
and access right.
Improve this by testing if the USB error is a permission error. If so log an error message and some hints
on how to solve it.