snagrecover: fix am335x cleanup option silently dropping "Done" message#89
Merged
Merged
Conversation
tprrt
changed the title
There was a problem hiding this comment.
Pull request overview
Fixes the -c (cleanup) option path in am335x_usb_setup.sh so the "Done" message is printed correctly after running cleanup, rather than being passed as an argument to cleanup().
Changes:
- Separate
cleanupinvocation fromecho "Done"in the-coption handler to ensure the message is printed. - Minor shell control-flow adjustment via the added command separator.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rgantois
reviewed
Apr 24, 2026
In the -c (cleanup) getopts branch, `echo "Done"` was passed as an argument to cleanup() instead of running as a separate command. The missing semicolon caused the message to never be printed. Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
tprrt
force-pushed
the
dev/tprrt/fix-am335x-cleanup-option
branch
from
190b7c4 to
c20846a
Compare
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the -c (cleanup) getopts branch,
echo "Done"was passed as an argument to cleanup() instead of running as a separate command. The missing semicolon caused the message to never be printed.