Don't rely on Class#name for model naming #217
Closed
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on `Class#name` for model naming breaks compatibility with anonymous models. The `ActiveModel::Naming#model_name` method is preferred Also, don’t attempt to get help text for nil objects. This was previously attempting to lookup `active record.help.nil_class.field_name` or similar.
pvmeerbe
pushed a commit
to pvmeerbe/rails-bootstrap-forms
that referenced
this pull request
Aug 12, 2016
taken from bootstrap-ruby#217 (@boffbowsh) Relying on Class#name for model naming breaks compatibility with anonymous models. The ActiveModel::Naming#model_name method is preferred Also, don’t attempt to get help text for nil objects. This was previously attempting to lookup activerecord.help.nil_class.field_name or similar.
pvmeerbe
pushed a commit
to pvmeerbe/rails-bootstrap-forms
that referenced
this pull request
Aug 12, 2016
taken from bootstrap-ruby#217 (@boffbowsh) Relying on Class#name for model naming breaks compatibility with anonymous models. The ActiveModel::Naming#model_name method is preferred Also, don’t attempt to get help text for nil objects. This was previously attempting to lookup activerecord.help.nil_class.field_name or similar.
pvmeerbe
pushed a commit
to pvmeerbe/rails-bootstrap-forms
that referenced
this pull request
Aug 31, 2016
taken from bootstrap-ruby#217 (@boffbowsh) Relying on Class#name for model naming breaks compatibility with anonymous models. The ActiveModel::Naming#model_name method is preferred Also, don’t attempt to get help text for nil objects. This was previously attempting to lookup activerecord.help.nil_class.field_name or similar.
mattbrictson
pushed a commit
that referenced
this pull request
Aug 31, 2016
* Don't rely on Class#name for model naming taken from #217 (@boffbowsh) Relying on Class#name for model naming breaks compatibility with anonymous models. The ActiveModel::Naming#model_name method is preferred Also, don’t attempt to get help text for nil objects. This was previously attempting to lookup activerecord.help.nil_class.field_name or similar. * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on
Class#namefor model naming breaks compatibility withanonymous models. The
ActiveModel::Naming#model_namemethod ispreferred
Also, don’t attempt to get help text for nil objects. This was
previously attempting to lookup
activerecord.help.nil_class.field_nameor similar.