Don't rely on Class#name for model naming #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi, thanks for the PR (including tests, awesome!). I haven't had a chance to review yet, but it is on my todo list. |
Contributor
|
Excellent work, thank you! 🙇 Can you also add an entry to the CHANGELOG under the "pending release" heading, please? Then I will merge this PR. |
Contributor
Author
|
done |
Contributor
|
Can you resolve the merge conflicts and rebase, please? Your changelog entry will need to go under the new "pending release" section. Thanks for your continued help on this! |
taken from bootstrap-ruby#217 (@boffbowsh) Relying on Class#name for model naming breaks compatibility with anonymous models. The ActiveModel::Naming#model_name method is preferred Also, don’t attempt to get help text for nil objects. This was previously attempting to lookup activerecord.help.nil_class.field_name or similar.
Contributor
Author
|
no problem & done |
Contributor
|
Thank you 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taken from #217 (@boffbowsh)
Relying on Class#name for model naming breaks compatibility with
anonymous models. The ActiveModel::Naming#model_name method is
preferred
Also, don’t attempt to get help text for nil objects. This was
previously attempting to lookup activerecord.help.nil_class.field_name or similar.