Fix alias_method_chain deprecation messages in Rails 5 #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails 5, `alias_method_chain` is deprecated in favor of `Module.prepend`. However, `prepend` is only available in Ruby 2.0+, and we still want to support Ruby 1.9. Furthermore, the `*_without_bootstrap` aliases that `alias_method_chain` creates are genuinely useful for users of bootstrap_form, because there are some cases where you don't want the Bootstrap-specific markup. Essentially, we want the traditional `alias_method_chain` behavior, but without the pesky deprecation warnings. This commit reimplements `alias_method_chain` under a new name, `bootstrap_method_alias`. This allows us to keep the behavior the same and avoid the deprecation warnings.
mattbrictson
changed the title
Contributor
|
looks great to me 👍 |
|
This is a really well thought out fix for the deprecation notices. Well done @mattbrictson! 👍 |
Closed
Contributor
|
Now that Rails 5 is out, could this be released as a new version? |
|
Until new version is out, Rails 5 users can pull directly from GitHub with this in their Gemfile: |
Contributor
|
Obviously, but I don't prefer relying on a git repo. Also, |
Contributor
Author
Done: https://rubygems.org/gems/bootstrap_form/versions/2.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 5,
alias_method_chainis deprecated in favor ofModule.prepend. However,prependis only available in Ruby 2.0+, and we still want to support Ruby 1.9.Furthermore, the
*_without_bootstrapaliases thatalias_method_chaincreates are genuinely useful for users of bootstrap_form, because there are some cases where you don't want the Bootstrap-specific markup.Essentially, we want the traditional
alias_method_chainbehavior, but without the pesky deprecation warnings. This commit reimplementsalias_method_chainunder a new name,bootstrap_method_alias. This allows us to keep the behavior the same and avoid the deprecation warnings.Fixes #253.