Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## [Pending Release][]

Bugfixes:
- Fix getting help text for elements when using anonymous models (see [issue 282](https://github.com/bootstrap-ruby/rails-bootstrap-forms/issues/282))
- Your contribution here!

Features:
Expand Down
22 changes: 14 additions & 8 deletions lib/bootstrap_form/form_builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -425,15 +425,21 @@ def inputs_collection(name, collection, value, text, options = {}, &block)
end

def get_help_text_by_i18n_key(name)
underscored_scope = "activerecord.help.#{object.class.name.underscore}"
downcased_scope = "activerecord.help.#{object.class.name.downcase}"
help_text = I18n.t(name, scope: underscored_scope, default: '').presence
help_text ||= if text = I18n.t(name, scope: downcased_scope, default: '').presence
warn "I18n key '#{downcased_scope}.#{name}' is deprecated, use '#{underscored_scope}.#{name}' instead"
text
end
if object

# ActiveModel::Naming 3.X.X does not support .name; it is supported as of 4.X.X
partial_scope = object.class.model_name.respond_to?(:name) ? object.class.model_name.name : object.class.model_name

help_text
underscored_scope = "activerecord.help.#{partial_scope.underscore}"
downcased_scope = "activerecord.help.#{partial_scope.downcase}"
help_text = I18n.t(name, scope: underscored_scope, default: '').presence
help_text ||= if text = I18n.t(name, scope: downcased_scope, default: '').presence
warn "I18n key '#{downcased_scope}.#{name}' is deprecated, use '#{underscored_scope}.#{name}' instead"
text
end
help_text
end
end

end
end
32 changes: 32 additions & 0 deletions test/special_form_class_models_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
require 'test_helper'

class SpecialFormClassModelsTest < ActionView::TestCase
include BootstrapForm::Helper

test "Anonymous models are supported for form builder" do
user_klass = Class.new(User)
def user_klass.model_name
ActiveModel::Name.new(User)
end

@user = user_klass.new(email: 'steve@example.com', password: 'secret', comments: 'my comment')
@builder = BootstrapForm::FormBuilder.new(:user, @user, self, {})
@horizontal_builder = BootstrapForm::FormBuilder.new(:user, @user, self, {layout: :horizontal, label_col: "col-sm-2", control_col: "col-sm-10"})
I18n.backend.store_translations(:en, {activerecord: {help: {user: {password: "A good password should be at least six characters long"}}}})

expected = %{<div class="form-group"><label class="control-label" for="user_misc">Misc</label><input class="form-control" id="user_misc" name="user[misc]" type="date" /></div>}
assert_equal expected, @builder.date_field(:misc)
end


test "Nil models are supported for form builder" do
@user = nil
@builder = BootstrapForm::FormBuilder.new(:user, @user, self, {})
@horizontal_builder = BootstrapForm::FormBuilder.new(:user, @user, self, {layout: :horizontal, label_col: "col-sm-2", control_col: "col-sm-10"})
I18n.backend.store_translations(:en, {activerecord: {help: {user: {password: "A good password should be at least six characters long"}}}})

expected = %{<div class="form-group"><label class="control-label" for="user_misc">Misc</label><input class="form-control" id="user_misc" name="user[misc]" type="date" /></div>}
assert_equal expected, @builder.date_field(:misc)
end

end