Skip to content

Add argument storage_quota to forced_result. Avoids override by client.#4091

Merged
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
m3nu:master
Oct 3, 2018
Merged

Add argument storage_quota to forced_result. Avoids override by client.#4091
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
m3nu:master

Conversation

@m3nu
Copy link
Copy Markdown
Contributor

@m3nu m3nu commented Oct 2, 2018

Without this, the client will always override the storage_quota set at the server.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 2, 2018

Codecov Report

Merging #4091 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4091      +/-   ##
==========================================
+ Coverage   84.29%   84.44%   +0.15%     
==========================================
  Files          37       37              
  Lines        9381     9382       +1     
  Branches     1556     1556              
==========================================
+ Hits         7908     7923      +15     
+ Misses       1027     1015      -12     
+ Partials      446      444       -2
Impacted Files Coverage Δ
src/borg/archiver.py 81.87% <100%> (+0.38%) ⬆️
src/borg/archive.py 84% <0%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28d402...93b968c. Read the comment docs.

@ThomasWaldmann
Copy link
Copy Markdown
Member

Oops.

Can you file a bug for this, so it can be referenced from the change log?

@m3nu
Copy link
Copy Markdown
Contributor Author

m3nu commented Oct 2, 2018

Related issue: #4093

@ThomasWaldmann
Copy link
Copy Markdown
Member

Thanks!

@ThomasWaldmann ThomasWaldmann merged commit 62de891 into borgbackup:master Oct 3, 2018
@ThomasWaldmann
Copy link
Copy Markdown
Member

can you also do a PR for 1.1-maint, please?

@ThomasWaldmann
Copy link
Copy Markdown
Member

does not apply to 1.0-maint (no storage quotas there).

@m3nu
Copy link
Copy Markdown
Contributor Author

m3nu commented Oct 3, 2018

OK. Adding a PR for 1.1-maint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants