Add storage_quota for forced_result if set by serve-command.#4095
Merged
ThomasWaldmann merged 1 commit intoborgbackup:1.1-maintfrom Oct 3, 2018
m3nu:1.1-maint
Merged
Add storage_quota for forced_result if set by serve-command.#4095ThomasWaldmann merged 1 commit intoborgbackup:1.1-maintfrom m3nu:1.1-maint
ThomasWaldmann merged 1 commit intoborgbackup:1.1-maintfrom
m3nu:1.1-maint
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.1-maint #4095 +/- ##
============================================
+ Coverage 84.35% 84.45% +0.1%
============================================
Files 23 23
Lines 9381 9382 +1
Branches 1603 1603
============================================
+ Hits 7913 7924 +11
+ Misses 1019 1012 -7
+ Partials 449 446 -3
Continue to review full report at Codecov.
|
enkore
reviewed
Oct 6, 2018
| result.restrict_to_paths = forced_result.restrict_to_paths | ||
| result.restrict_to_repositories = forced_result.restrict_to_repositories | ||
| result.append_only = forced_result.append_only | ||
| result.storage_quota = forced_result.storage_quota |
Contributor
There was a problem hiding this comment.
Fail open vs. fail closed -- instead of specifying what options are blacklisted (i.e. not overriden), consider whitelisting instead.
Contributor
There was a problem hiding this comment.
Sounds great. I am just not sure yet what is the closed and what the open part in fail close/open with regard to this. As only expected options are explicitly specified, isn't this already whitelisting?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4093 and #4091