requirements: remove chardet < 6 pin, no longer needed with requests >= 2.32.6#9567
Merged
ThomasWaldmann merged 2 commits intoborgbackup:masterfrom Apr 13, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9567 +/- ##
==========================================
- Coverage 83.40% 83.38% -0.02%
==========================================
Files 87 87
Lines 15489 15489
Branches 2326 2326
==========================================
- Hits 12918 12916 -2
Misses 1821 1821
- Partials 750 752 +2 ☔ View full report in Codecov by Sentry. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the
chardet < 6pin fromrequirements.d/development.txtandrequirements.d/development.lock.txt.This constraint was added as a workaround because
requests <= 2.32.5emitted
RequestsDependencyWarningwhenchardet >= 6was installed,which caused noisy test output. Since
requests >= 2.32.6has now beenreleased with the upstream fix, this workaround pin is no longer needed.
Borg does not directly use
chardet— it was only pinned to silencewarnings from
requests. Removing it allows the package manager tofreely resolve
chardetwithout the artificial constraint.Fixes #9433
Checklist
master(or maintenance branch if only applicable there)toxor the relevant test subset)