Skip to content

requirements: remove chardet < 6 pin, no longer needed with requests >= 2.32.6#9567

Merged
ThomasWaldmann merged 2 commits intoborgbackup:masterfrom
charmikadi:fix/remove-chardet-pin
Apr 13, 2026
Merged

requirements: remove chardet < 6 pin, no longer needed with requests >= 2.32.6#9567
ThomasWaldmann merged 2 commits intoborgbackup:masterfrom
charmikadi:fix/remove-chardet-pin

Conversation

@charmikadi
Copy link
Copy Markdown
Contributor

Description

Remove the chardet < 6 pin from requirements.d/development.txt and
requirements.d/development.lock.txt.

This constraint was added as a workaround because requests <= 2.32.5
emitted RequestsDependencyWarning when chardet >= 6 was installed,
which caused noisy test output. Since requests >= 2.32.6 has now been
released with the upstream fix, this workaround pin is no longer needed.

Borg does not directly use chardet — it was only pinned to silence
warnings from requests. Removing it allows the package manager to
freely resolve chardet without the artificial constraint.

Fixes #9433

Checklist

  • PR is against master (or maintenance branch if only applicable there)
  • New code has tests and docs where appropriate
  • Tests pass (run tox or the relevant test subset)
  • Commit messages are clean and reference related issues

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.38%. Comparing base (cb83cc1) to head (18cb73c).
⚠️ Report is 12 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9567      +/-   ##
==========================================
- Coverage   83.40%   83.38%   -0.02%     
==========================================
  Files          87       87              
  Lines       15489    15489              
  Branches     2326     2326              
==========================================
- Hits        12918    12916       -2     
  Misses       1821     1821              
- Partials      750      752       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann merged commit 3246b0f into borgbackup:master Apr 13, 2026
15 of 16 checks passed
@ThomasWaldmann
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove chardet < 6 for requests >= 2.32.6

2 participants