CI: fix deprecation warnings - #9960
Merged
Merged
Conversation
- lint: bump astral-sh/ruff-action v3 -> v4.1.0.
v3 runs on node20, which is deprecated and force-run on node24 now.
v4 natively targets node24. No change in ruff version resolution.
v4 uses immutable releases and publishes no floating major tag,
so the exact version has to be pinned.
- vm_tests: stop using the deprecated "run" input of
cross-platform-actions/action. Split the step into a "Start VM" step
and a test step that uses the custom shell (shell: cpa.sh {0}), as
recommended by the action. File sync (runner->vm before, vm->runner
after) happens automatically, so the artifact / test-results.xml /
coverage.xml uploads keep working.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ThomasWaldmann
force-pushed
the
fix-ci-warnings
branch
from
July 27, 2026 19:57
3c55705 to
6cf7dfd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9960 +/- ##
==========================================
+ Coverage 85.68% 85.70% +0.01%
==========================================
Files 95 95
Lines 16799 16815 +16
Branches 2574 2577 +3
==========================================
+ Hits 14394 14411 +17
+ Misses 1669 1668 -1
Partials 736 736 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two deprecation warnings currently shown on CI runs.
lint: Node.js 20 deprecation
Bumped
astral-sh/ruff-actionv3 -> v4.1.0. Checked the manifests: v3.6.1 declaresusing: node20, v4.1.0 declaresusing: node24.The exact version has to be pinned: with v4 astral-sh switched to immutable releases and no longer publishes a floating
v4major tag (onlyv4.0.0andv4.1.0exist), so@v4does not resolve.Ruff version resolution itself is unchanged (pyproject-discovered, else
latest), and we don't pin ruff, so both v3 and v4 use the latest ruff.vm_tests: deprecated
runinputSplit the single
cross-platform-actions/actionstep into a "Start VM" step plus a test step using the recommended custom shell:The test script itself is unchanged apart from a 2-space dedent —
git diff -wshows only the two hunks above.Two behaviour details that matter here:
shell: cpa.sh {0}the helper syncs runner->vm before the script and vm->runner after, soartifacts/*,test-results.xmlandcoverage.xmlstill reach the later upload steps.shutdown_vm: its default flips fromtruetofalseoncerunis gone, which is what we want here — the VM has to survive into the test step.