chore(observability): pin Tempo image + fix size-diff workflow auth - #54
Merged
Conversation
Two small follow-ups to the recent observability work — both pure hygiene, no behavioural changes. Tempo image pinned by digest ---------------------------- PR #50 introduced `grafana/tempo:2.6.1` as a tag-only reference because OrbStack wasn't running when the commit was prepared. Every other image in the observability stack (prometheus, grafana, loki, promtail, alertmanager, postgres-exporter, node-exporter) is pinned to a specific `@sha256:` digest for supply-chain hygiene. Tempo now matches: grafana/tempo:2.6.1@sha256:ef4384fce6e8ad22b95b243d8fc165628cda655376fd50e7850536ad89d71d50 size-diff workflow github_token ------------------------------- The `bundle-diff` workflow on every PR has been printing a red ✗ with `Parameter token or opts.auth is required` since #46 introduced the dashboard work. The action (`andresz1/size-limit-action@v1.8.0`) initialises Octokit *before* reading the env var GITHUB_TOKEN, so the env-based pass we had wasn't reaching it. Fix: pass the token explicitly as a `with:` input too. The env line stays as belt-and-braces in case a future action version flips back to env. Result: no more spurious red ✗ on PRs that touch apps/ui. Verification: docker compose config dry-run exits 0 with the pinned Tempo image; workflow YAML still parses; pre-push gate green. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small follow-ups to the recent observability work — both pure
hygiene, no behavioural changes.
Tempo image pinned by digest
PR #50 introduced
grafana/tempo:2.6.1as a tag-only referencebecause OrbStack wasn't running when the commit was prepared. Every
other image in the observability stack (prometheus, grafana, loki,
promtail, alertmanager, postgres-exporter, node-exporter) is pinned
to a specific
@sha256:digest for supply-chain hygiene. Tempo nowmatches:
grafana/tempo:2.6.1@sha256:ef4384fce6e8ad22b95b243d8fc165628cda655376fd50e7850536ad89d71d50
size-diff workflow github_token
The
bundle-diffworkflow on every PR has been printing a red ✗with
Parameter token or opts.auth is requiredsince #46 introducedthe dashboard work. The action (
andresz1/size-limit-action@v1.8.0)initialises Octokit before reading the env var GITHUB_TOKEN, so
the env-based pass we had wasn't reaching it. Fix: pass the token
explicitly as a
with:input too. The env line stays asbelt-and-braces in case a future action version flips back to env.
Result: no more spurious red ✗ on PRs that touch apps/ui.
Verification: docker compose config dry-run exits 0 with the pinned
Tempo image; workflow YAML still parses; pre-push gate green.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com