✨ (custom logger) add option to supply custom logger#72
Merged
maybeanerd merged 6 commits intobotblock:masterfrom Apr 8, 2021
Merged
✨ (custom logger) add option to supply custom logger#72maybeanerd merged 6 commits intobotblock:masterfrom
maybeanerd merged 6 commits intobotblock:masterfrom
Conversation
maybeanerd
requested changes
Apr 2, 2021
Contributor
Author
Oh boi here we go again, tbh I didn't realize they changed, I just hacked my changes in and pushed it. I have no idea why they changed tho |
advaith1
changed the title
maybeanerd
requested changes
Apr 7, 2021
Member
maybeanerd
left a comment
maybeanerd
left a comment
There was a problem hiding this comment.
some more questions, but in general no huge issues, just some optimization/cleanup
maybeanerd
approved these changes
Apr 8, 2021
at some point I want to just replace this with all contributors (https://allcontributors.org/docs/en/overview), but as long as this file exists, ill make sure its up to date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71