Merged
Conversation
Member
maybeanerd
commented
Aug 13, 2021
maybeanerd
commented
- fix feat: add discord.js v13 support #83 (for now that only encompasses the shardID to shardId change)
- rename filenames to make more sense:
- blapi.ts -> main.ts
- bttps.ts -> requests.ts
- bump minor version
- blapi.ts -> main.ts - bttps.ts -> requests.ts - bump minor version - adjust type to support both discordjs v12 and v13 clients passed (for now that only encompasses the shardID to shardId change)
Member
Author
|
@advaith1 since you found the differences, is there anything else you are aware of? Is this the change you were expecting? |
Member
Author
|
tested the typing with d.js v13, and it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.