Drop $schema property from lists + legacy IDs#4
Merged
MattIPv4 merged 4 commits intobotblock:masterfrom Aug 21, 2022
A5rocks:drop-schemas
Merged
Drop $schema property from lists + legacy IDs#4MattIPv4 merged 4 commits intobotblock:masterfrom A5rocks:drop-schemas
MattIPv4 merged 4 commits intobotblock:masterfrom
A5rocks:drop-schemas
Conversation
MattIPv4
requested changes
Aug 16, 2022
Member
MattIPv4
left a comment
MattIPv4
left a comment
There was a problem hiding this comment.
👀 I think https://github.com/botblock/api-worker/blob/master/src/routes/legacy-ids.js also needs to drop the property?
Co-authored-by: Matt Cowley <me@mattcowley.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should work. Like last time, I have not tested this so make sure to run through with a careful eye.