fix(android): fail closed without exact native symbols#4
Merged
Conversation
Signed-off-by: Quinn Rafferty <quinn.rafferty@hands.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libhandscrash.sois present.debug_info, and APK/archive/manifest ELF build IDs for every ABIWhy
The current copy-ready Android examples can publish an APK successfully without a
native-symbolsbuild asset. Native crashes are then permanently unsymbolicatable because APK/AAR libraries are stripped and exact unstripped bytes cannot be reconstructed later.Validation
bash -n scripts/publish-android.sh scripts/validate-android-native-symbols.sh examples/generic/*.sh tests/*.shtests/test-validate-android-native-symbols.shauto--symbolsactionlintpasses for the CI and GitHub workflow examplesandroid-sdk-v0.11.2AAR + native-symbols classifier: 3 ABI build-ID validation passesRelease note
After merge, move the floating
v1tag to this commit so existing@v1consumers receive the integrity fix. This intentionally makes pipelines containinglibhandscrash.sofail until they provide the matching classifier;native-symbols-policy: disabledremains an explicit emergency opt-out.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.