feat(electron): Crashpad minidump crash ingest + symbolication (server side) - #110
Merged
Merged
Conversation
…r side) Adds the Electron/Crashpad crash lane (server foundation) alongside the existing native/dSYM symbolication flows: - worker: POST /public/v2/apps/:slug/minidump ingests Electron crashReporter's multipart (upload_file_minidump + Sentry-electron-style annotations), stores the dump as a crash-ticket attachment, folds annotations into metadata (product_type=electron, process_type, version, channel, guid, extras), and fires symbolicateMinidumpCrashTicket. Client-key gated (query or header), rate-limited like feedback. - worker: symbolicateMinidumpCrashTicket fetches the minidump + the version's breakpad-symbols asset, calls the container, and appends the symbolicated stack as a quiver-symbolicate internal comment (reuses the existing crash UI panel). Without symbols it still posts module+offset frames + an upload tip. - container: POST /symbolicate-minidump rebuilds the Breakpad symbol tree from each .sym MODULE header (CI can zip flat), runs minidump-stackwalk --json, returns the crashing thread's frames + rendered stack. Dockerfile installs minidump-stackwalk (rust-minidump) via a bookworm builder stage. - cli: publish-electron --symbols uploads Breakpad symbols as a breakpad-symbols support asset per version. Tests: minidump ingest creates an electron crash ticket + attachment and maps annotations; bad client key rejected. 87 worker tests pass; worker, container, and cli tsc clean. Follow-up: Electron SDK (clients/electron, main+renderer entry points) and integration docs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Server-side foundation for the Electron/Crashpad crash lane (task #97), completing the last row of the symbolication matrix. Mirrors the existing native/dSYM flows so Electron crashes auto-symbolicate into a
quiver-symbolicateticket comment.This is blocks 1–3 of 5. Follow-up PR: the Electron SDK (
clients/electron, main+renderer entry points) + integration docs.How
Ingest —
POST /public/v2/apps/:slug/minidumpcrashReporter's multipart (upload_file_minidump+ flat Sentry-electron-style annotations: version, version_code, channel/environment, process_type, guid, arbitraryextra/globalExtra).product_type=electron, mapped well-known keys to columns), fires symbolication in the background.?client_key=query — Crashpad preserves the submitURL query — orX-Quiver-Client-Key), rate-limited like feedback.Symbolicate —
symbolicateMinidumpCrashTicket+ containerPOST /symbolicate-minidumpbreakpad-symbolsasset, POSTs both to the container, appends the crashing-thread stack as aquiver-symbolicateinternal comment (renders in the existing crash panel). No symbols → still posts module+offset frames + an actionable upload tip..symMODULEheader (so CI can zip them flat), runsminidump-stackwalk --json(rust-minidump), returns crashing-thread frames + rendered text. Dockerfile installsminidump-stackwalkvia a bookworm builder stage (glibc matches runtime).CLI —
publish-electron --symbols.zip) as abreakpad-symbolssupport asset per version.Tests
Minidump ingest → electron crash ticket + attachment, annotation mapping (product_type/process_type/version/channel/guid/extras); bad client key → 401. 87 worker tests pass. worker + container + cli
tsc --noEmitclean.Client side (next PR)
Real
@oranix/quiver-electronSDK with/main(crashReporter init +render-process-gone/child-process-gonelisteners + scope/context) and/renderer(scope + IPC forward) entry points, à la@sentry/electron— the client is referenced in both main and renderer.🤖 Generated with Claude Code