feat(integration/slack): Implemented markdown to slack markdown transformer#14822
Merged
Horisofine merged 10 commits intomasterfrom Jan 20, 2026
Merged
feat(integration/slack): Implemented markdown to slack markdown transformer#14822Horisofine merged 10 commits intomasterfrom
Horisofine merged 10 commits intomasterfrom
Conversation
mikee-b
reviewed
Jan 19, 2026
| .describe( | ||
| 'Field text must be defined but it is ignored if blocks are provided. In this situation, the text must be provided in the blocks array' | ||
| ) | ||
| .optional(), |
Contributor
There was a problem hiding this comment.
Suggestion: I think this is what's preventing you from releasing a patch or a minor rather than a major. If this is not critical, maybe we can put optional back so we can avoid having to bump a major.
Contributor
There was a problem hiding this comment.
Good catch, Mikee is correct here.
Contributor
Author
There was a problem hiding this comment.
I was getting an issue deploying due to optional. That's why I removed it but I put it back since the issue is no longer occuring.
JustinBordage
approved these changes
Jan 19, 2026
JustinBordage
requested changes
Jan 19, 2026
JustinBordage
changed the title
… schema to make 'text' field optional
JustinBordage
requested changes
Jan 20, 2026
| import { test, expect, vi } from 'vitest' | ||
| import { replaceMentions, Mention } from './replace-mentions' | ||
|
|
||
| test('returns undefined if text is undefined', () => { |
Contributor
There was a problem hiding this comment.
issue: The unit test should be re-implemented seeing that we are reverting the "optional"
mikee-b
previously approved these changes
Jan 20, 2026
JustinBordage
approved these changes
Jan 20, 2026
Horisofine
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves SH-242.
This PR contains the implementation of the slack markdown transformer. This allows bot developers to input markdown within the text and get rich text.
Contains: