Skip to content

Fix some spelling mistakes#2650

Merged
allardy merged 2 commits intobotpress:patch/12-2-4from
asashour:spellings
Dec 4, 2019
Merged

Fix some spelling mistakes#2650
allardy merged 2 commits intobotpress:patch/12-2-4from
asashour:spellings

Conversation

@asashour
Copy link
Copy Markdown
Contributor

No description provided.

@asashour
Copy link
Copy Markdown
Contributor Author

asashour commented Nov 28, 2019

This is one of some potential PRs to be raised, to fix various spellings mistakes.

They are split because otherwise the change would be huge and difficult to review.

On the other hand, the latest Visual Studio Code automatically formats the code a little different, by putting some spaces here and their, I hope it doesn't bother in future PRs, specially I see we have "Run Prettier on codebase" in the PR checks.

Also, is ok if multiple commits are created, one for each 'word', and the PR is squashed later? What are your preferences?

Copy link
Copy Markdown
Member

@allardy allardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! It would be better to do like this PR and include multiple typo fix in the same commit.
However it would be nice if you could open a different PR for the documentation / code

@allardy allardy changed the base branch from master to patch/12-2-4 December 4, 2019 19:33
@allardy allardy merged commit a8f608e into botpress:patch/12-2-4 Dec 4, 2019
@asashour asashour deleted the spellings branch December 4, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants