This repository was archived by the owner on Jun 10, 2025. It is now read-only.
Use 'NETCDF4' as default format for DataFile - #35
Merged
Conversation
`NETCDF4` format is pretty universally supported now, and is probably the least surprising default.
loeiten
approved these changes
Aug 13, 2021
loeiten
left a comment
loeiten
left a comment
Member
There was a problem hiding this comment.
Not sure why the GitHub actions are not running, but the PR makes sense to me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NETCDF4format is pretty universally supported now, and is probably the least surprising default.Technically I guess this is a breaking change - it will change the file format for some workflows - but all our utilities that read 'NETCDF3' files will read 'NETCDF4' so this shouldn't cause any problems.