Chore: Refactoring annotation mode logic into controllers#15
Merged
pramodsum merged 13 commits intobox:masterfrom Nov 6, 2017
Merged
Chore: Refactoring annotation mode logic into controllers#15pramodsum merged 13 commits intobox:masterfrom
pramodsum merged 13 commits intobox:masterfrom
Conversation
pramodsum
force-pushed
the
annotations
branch
3 times, most recently
from
4ce8554 to
0b91b77
Compare
JustinHoldstock
approved these changes
Nov 1, 2017
Contributor
JustinHoldstock
left a comment
JustinHoldstock
left a comment
There was a problem hiding this comment.
Looks good to me, other than the old "default to page 1" discussion we were having, when the repo was private
Contributor
Author
|
I made a ticket to address that in a separate PR as it might require some other refactoring in the process. |
pramodsum
force-pushed
the
annotations
branch
from
25951f2 to
5ccb54d
Compare
Contributor
Author
|
Agreed. I can make a ticket to make one per BoxAnnotations instance. |
pramodsum
force-pushed
the
annotations
branch
2 times, most recently
from
133e822 to
95c77a1
Compare
pramodsum
force-pushed
the
annotations
branch
from
95c77a1 to
eca131d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submitting #7