Chore: Refactoring annotation mode logic into controllers#7
Closed
pramodsum wants to merge 2 commits intobox:masterfrom
pramodsum:annotations
Closed
Chore: Refactoring annotation mode logic into controllers#7pramodsum wants to merge 2 commits intobox:masterfrom pramodsum:annotations
pramodsum wants to merge 2 commits intobox:masterfrom
pramodsum:annotations
Conversation
pramodsum
force-pushed
the
master
branch
18 times, most recently
from
b5efd2a to
3521db1
Compare
Contributor
JustinHoldstock
left a comment
JustinHoldstock
left a comment
There was a problem hiding this comment.
That's some serious cleanup! See my comment, then lgtm (and tests)
| */ | ||
| getThreadByID(threadID) { | ||
| let thread = null; | ||
| Object.keys(this.threads).forEach((page) => { |
Contributor
There was a problem hiding this comment.
Could you optimize this with .some() instead of .forEach()? There's no point in iterating the ENTIRE list if you've already found the item you're looking for
Contributor
Author
|
Will re-open in a separate PR w/ the merge conflicts sorted out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.