feat(permissions): Add checks for new permission values on file object#485
Merged
mergify[bot] merged 2 commits intobox:masterfrom May 11, 2020
Merged
feat(permissions): Add checks for new permission values on file object#485mergify[bot] merged 2 commits intobox:masterfrom
mergify[bot] merged 2 commits intobox:masterfrom
Conversation
mingzexiao6
reviewed
May 11, 2020
| }); | ||
|
|
||
| it('should return false if permissions do not exist', () => { | ||
| test('should return false if permissions do not exist', () => { |
Contributor
There was a problem hiding this comment.
Why not use the alias?
Collaborator
Author
There was a problem hiding this comment.
The convention is it = Karma and test = Jest. Most of the other tests use test.
mingzexiao6
approved these changes
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.