feat(scroll): emit 'annotations_initialized' when annotations first initializes.#515
Merged
mergify[bot] merged 8 commits intobox:masterfrom Jun 16, 2020
Merged
Conversation
* accommodate changes in content-preview to send ready event with annotations once annotations are loaded.
mickr
changed the title
jstoffan
reviewed
Jun 12, 2020
jstoffan
reviewed
Jun 12, 2020
jstoffan
reviewed
Jun 12, 2020
Collaborator
|
Should we emit |
Collaborator
Author
The document isn't ready to scroll when the fetch call completes as there are no annotated elements and the page elements are not loaded yet. |
* PR Feedback
jstoffan
reviewed
Jun 15, 2020
* Refactor to emit 'annotations_initialized' using eventing middleware
* Remove un-used class variable
jstoffan
reviewed
Jun 15, 2020
jstoffan
reviewed
Jun 15, 2020
jstoffan
reviewed
Jun 16, 2020
* PR Feedback
Collaborator
|
Can we update the PR title? |
jstoffan
reviewed
Jun 16, 2020
jstoffan
reviewed
Jun 16, 2020
* PR Feedback
mickr
changed the title
jstoffan
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
box/box-content-preview#1224 depends on this change