Skip to content

feat(hotkeys): Press Esc to exit annotations mode#517

Merged
jstoffan merged 2 commits intobox:masterfrom
mingzexiao6:exit-mode-2
Jun 17, 2020
Merged

feat(hotkeys): Press Esc to exit annotations mode#517
jstoffan merged 2 commits intobox:masterfrom
mingzexiao6:exit-mode-2

Conversation

@mingzexiao6
Copy link
Contributor

@mingzexiao6 mingzexiao6 commented Jun 16, 2020

  • Tests

@mingzexiao6 mingzexiao6 requested a review from a team as a code owner June 16, 2020 18:07
@mingzexiao6 mingzexiao6 marked this pull request as draft June 16, 2020 18:08
@mingzexiao6 mingzexiao6 marked this pull request as ready for review June 16, 2020 21:59
@mingzexiao6 mingzexiao6 force-pushed the exit-mode-2 branch 2 times, most recently from b1433bb to 06ad3f9 Compare June 16, 2020 22:04
return;
}

event.preventDefault();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this causing an issue?

@jstoffan
Copy link
Collaborator

@Mergifyio refresh

@jstoffan jstoffan closed this Jun 17, 2020
@jstoffan jstoffan reopened this Jun 17, 2020
@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2020

Command refresh: success

@jstoffan jstoffan merged commit c86ad0b into box:master Jun 17, 2020
@mingzexiao6 mingzexiao6 deleted the exit-mode-2 branch August 12, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants