feat(highlight): Reset isPromoting when toggle mode#581
Merged
mergify[bot] merged 2 commits intobox:masterfrom Sep 10, 2020
Merged
feat(highlight): Reset isPromoting when toggle mode#581mergify[bot] merged 2 commits intobox:masterfrom
mergify[bot] merged 2 commits intobox:masterfrom
Conversation
ConradJChan
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the case that when user is promoting (PopupReply shows and toolbar button is temporarily active) and user clicks toolbar button to exit temporary highlight mode, PopupReply and Staged annotation should disappear.