feat(highlights): Better rect smoothing#596
Merged
mergify[bot] merged 5 commits intobox:masterfrom Sep 17, 2020
Merged
Conversation
mingzexiao6
reviewed
Sep 16, 2020
mingzexiao6
reviewed
Sep 16, 2020
mingzexiao6
previously approved these changes
Sep 17, 2020
ConradJChan
changed the title
ConradJChan
force-pushed
the
smoothen-rect-more
branch
from
daed458 to
f5c75bb
Compare
mingzexiao6
approved these changes
Sep 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempted an improvement to the existing rect combining strategy. Previously, we would round the rect's y coordinate to the nearest integer and use that as the key to combine all of those rects into such "rows".
This approach attempts to combine rects that have the y coordinate within a certain threshold (% of height).
An additional enhancement is that it also combines based on whether the x coordinate is also within a certain threshold (% of width).
Before:
After:
Before:
After:
Before:
After:
