Skip to content

fix(highlights): Allows highlight anchors to receive focus#598

Merged
mergify[bot] merged 2 commits intobox:masterfrom
ConradJChan:simplify-highlight-target
Sep 22, 2020
Merged

fix(highlights): Allows highlight anchors to receive focus#598
mergify[bot] merged 2 commits intobox:masterfrom
ConradJChan:simplify-highlight-target

Conversation

@ConradJChan
Copy link
Contributor

Fixes an issue where the SVG anchor for the highlight annotation target never received focus. As a result, you would get into this situation where:

  • You select a region annotation (document.activeElement is the region annotation button)
  • Region annotation is set as active
  • You select a highlight annotation (document.activeElement is the region annotation button)
  • Highlight annotation is set as active
  • You select the region annotation again (document.activeElement is the region annotation button)
  • Highlight annotation remains active

GIF of the issue:
Highlight not focusing

@ConradJChan ConradJChan requested a review from a team as a code owner September 22, 2020 05:53
@mergify mergify bot merged commit 2278b0c into box:master Sep 22, 2020
@ConradJChan ConradJChan deleted the simplify-highlight-target branch September 22, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants