fix(highlight): getBoundingRect to handle negative y-axis#637
Merged
mergify[bot] merged 3 commits intobox:masterfrom Nov 18, 2020
Merged
fix(highlight): getBoundingRect to handle negative y-axis#637mergify[bot] merged 3 commits intobox:masterfrom
mergify[bot] merged 3 commits intobox:masterfrom
Conversation
jstoffan
reviewed
Nov 17, 2020
jstoffan
approved these changes
Nov 18, 2020
mingzexiao6
approved these changes
Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Number.MIN_VALUEis actually the smallest positive number closest to zero. Combined with negative y-axis values for client rects (which happens when the text selection is involved with a vertical page scroll) resulted in incorrect logic when attempting to smoothen and combine the rects.Before
After