Skip to content

feat(share): Deprecate share#4549

Merged
mergify[bot] merged 2 commits into
masterfrom
buie-deprecate-share
May 11, 2026
Merged

feat(share): Deprecate share#4549
mergify[bot] merged 2 commits into
masterfrom
buie-deprecate-share

Conversation

@reneshen0328
Copy link
Copy Markdown
Contributor

@reneshen0328 reneshen0328 commented May 11, 2026

What

  • Safely remove share folder

Summary by CodeRabbit

  • Chores
    • Removed Share Menu feature and associated assets including documentation, styling, tests, and internationalization files.

Review Change Stack

@reneshen0328 reneshen0328 requested a review from a team as a code owner May 11, 2026 18:35
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ba0e599f-de07-4f9f-8e9c-155efce4f049

📥 Commits

Reviewing files that changed from the base of the PR and between 221ceb4 and 931ab0b.

⛔ Files ignored due to path filters (1)
  • i18n/en-US.properties is excluded by !i18n/**
📒 Files selected for processing (6)
  • src/features/share/README.md
  • src/features/share/ShareMenu.js
  • src/features/share/ShareMenu.scss
  • src/features/share/__tests__/ShareMenu.test.js
  • src/features/share/index.js
  • src/features/share/messages.js
💤 Files with no reviewable changes (6)
  • src/features/share/README.md
  • src/features/share/index.js
  • src/features/share/ShareMenu.scss
  • src/features/share/messages.js
  • src/features/share/tests/ShareMenu.test.js
  • src/features/share/ShareMenu.js

Walkthrough

This pull request removes the entire ShareMenu feature from the share module. The component, related exports, internationalization messages, styles, tests, and documentation are completely deleted.

Changes

ShareMenu Feature Removal

Layer / File(s) Summary
Public API Boundary
src/features/share/index.js
Default export re-export from ./ShareMenu is removed.
Component Implementation
src/features/share/ShareMenu.js
Permission constants (OWNER_COOWNER_ONLY, INSUFFICIENT_PERMISSIONS), ShareMenu React component with invite/share menu item rendering, propTypes validation, and module exports are deleted.
Supporting Resources
src/features/share/messages.js, src/features/share/ShareMenu.scss
Internationalization message catalog (react-intl defineMessages) and component styles (.share-menu, .menu-item, .share-option-description) are removed.
Test Suite
src/features/share/__tests__/ShareMenu.test.js
Test setup, rendering tests, permission-restriction tests, and parameterized tests for invite/share-link capabilities and shared-link permission messages are deleted.
Documentation
src/features/share/README.md
Component usage documentation and JSX example showing ShareMenu props and handlers are removed.

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ready-to-merge

Suggested reviewers

  • tjuanitas
  • jpan-box

🐰 A menu once shared, now fades away,
Files once full of code today decay,
Tests and styles, messages too,
All removed—a cleanup true!
The share feature says its goodbye. 👋

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides a brief summary ('Safely remove share folder') but lacks detailed context on why the feature is being deprecated, migration guidance, or impact analysis. Consider expanding the description with deprecation rationale, any migration steps for users, and verification that all dependencies have been addressed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(share): Deprecate share' clearly and accurately describes the main change: removing the share folder functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch buie-deprecate-share

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot added the queued label May 11, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 11, 2026

Merge Queue Status

  • Entered queue2026-05-11 19:54 UTC · Rule: Automatic strict merge
  • Checks passed · in-place
  • Merged2026-05-11 20:06 UTC · at cb01f762d86a8085235520c52a598874fb3286cc · squash

This pull request spent 11 minutes 50 seconds in the queue, including 11 minutes 14 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Summary
    • check-neutral = Summary
    • check-skipped = Summary
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_test_build
    • check-neutral = lint_test_build
    • check-skipped = lint_test_build
  • any of [🛡 GitHub branch protection]:
    • check-success = license/cla
    • check-neutral = license/cla
    • check-skipped = license/cla
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_pull_request
    • check-neutral = lint_pull_request
    • check-skipped = lint_pull_request

@mergify mergify Bot merged commit 6a788b4 into master May 11, 2026
11 checks passed
@mergify mergify Bot deleted the buie-deprecate-share branch May 11, 2026 20:06
@mergify mergify Bot removed the queued label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants