Skip to content

feat(query-bar): Deprecate query-bar#4550

Merged
mergify[bot] merged 2 commits into
masterfrom
deprecate-query-bar
May 12, 2026
Merged

feat(query-bar): Deprecate query-bar#4550
mergify[bot] merged 2 commits into
masterfrom
deprecate-query-bar

Conversation

@reneshen0328
Copy link
Copy Markdown
Contributor

@reneshen0328 reneshen0328 commented May 11, 2026

What

  • Safely remove query-bar folder

Summary by CodeRabbit

  • Chores
    • Removed the query bar feature and all related components from the application, including filtering capabilities, template selection, and column management functionality.

@reneshen0328 reneshen0328 requested a review from a team as a code owner May 11, 2026 19:06
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Walkthrough

This PR removes the entire query-bar feature module, including all React components (QueryBar, ColumnButton, TemplateButton, FilterButton), type definitions, constants, internationalization messages, stylesheets, test suites, and documentation.

Changes

Query Bar Feature Removal

Layer / File(s) Summary
Components Removed
src/features/query-bar/components/ColumnButton.js, ColumnButtonOverlay.js, TemplateButton.js, filter/FilterButton.js, filter/Condition.js, filter/ValueField.js
All six React component modules defining the query bar UI (template selection, filter panel, and column visibility toggle) are deleted.
Types, Constants, and Utilities
src/features/query-bar/flowTypes.js, constants.js, messages.js
Flow type definitions (ColumnType, ConditionType, ConnectorType, etc.), operator/connector constants, and i18n message descriptors are removed.
Main Entry & Module Export
src/features/query-bar/QueryBar.js, index.js
Top-level QueryBar component and the module's default export are removed, leaving no public entry point.
Test Coverage
src/features/query-bar/__tests__/*
All Jest test suites for components (ColumnButton.test.js, ColumnButtonOverlay.test.js, Condition.test.js, FilterButton.test.js, QueryBar.test.js, TemplateButton.test.js, ValueField.test.js) are deleted.
Styles & Fixtures
src/features/query-bar/styles/Condition.scss, QueryBarButtons.scss, components/fixtures.js
All SCSS stylesheets (194 + 155 lines) and fixture mock data are removed.
Documentation
src/features/query-bar/README.md
User-facing documentation describing the query bar demo and examples is removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

ready-to-merge

Suggested reviewers

  • tjuanitas
  • jpan-box
  • greg-in-a-box

Poem

A feature once grand, now fades away,
Query bars and filters, no more to stay.
Files deleted clean, in one swift sweep,
The query bar's dreams, in archives sleep. 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description clearly states the purpose ('Safely remove query-bar folder') but lacks detail on motivation, testing, impact assessment, and migration guidance expected in a deprecation PR. Expand description with: rationale for removal, any migration path for dependent code, testing performed, and verification that no other code relies on the query-bar component.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change—deprecating the query-bar feature by removing all its associated code and components.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deprecate-query-bar

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot added the queued label May 12, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 12, 2026

Merge Queue Status

  • Entered queue2026-05-12 22:34 UTC · Rule: Automatic strict merge
  • Checks started · in-place
  • 🚫 Left the queue2026-05-12 22:45 UTC · at 0124646be46e3b648c1bcd2c04a8e491c1ab4aa2

This pull request spent 10 minutes 23 seconds in the queue, with no time running CI.

Waiting for any of
  • check-neutral = lint_test_build
  • check-skipped = lint_test_build
  • check-success = lint_test_build
All conditions
  • any of [🛡 GitHub branch protection]:
    • check-neutral = lint_test_build
    • check-skipped = lint_test_build
    • check-success = lint_test_build
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Summary
    • check-neutral = Summary
    • check-skipped = Summary
  • any of [🛡 GitHub branch protection]:
    • check-success = license/cla
    • check-neutral = license/cla
    • check-skipped = license/cla
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_pull_request
    • check-neutral = lint_pull_request
    • check-skipped = lint_pull_request

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Copy link
Copy Markdown
Contributor

@jfox-box jfox-box left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM

@jfox-box jfox-box changed the title feat(quer-bar): Deprecate query-bar feat(query-bar): Deprecate query-bar May 12, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 12, 2026

Merge Queue Status

  • Entered queue2026-05-12 23:05 UTC · Rule: Automatic strict merge
  • Checks skipped · PR is already up-to-date
  • Merged2026-05-12 23:05 UTC · at 0124646be46e3b648c1bcd2c04a8e491c1ab4aa2 · squash

This pull request spent 17 seconds in the queue, including 2 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Summary
    • check-neutral = Summary
    • check-skipped = Summary
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_test_build
    • check-neutral = lint_test_build
    • check-skipped = lint_test_build
  • any of [🛡 GitHub branch protection]:
    • check-success = license/cla
    • check-neutral = license/cla
    • check-skipped = license/cla
  • any of [🛡 GitHub branch protection]:
    • check-success = lint_pull_request
    • check-neutral = lint_pull_request
    • check-skipped = lint_pull_request

@mergify mergify Bot merged commit 73e30c7 into master May 12, 2026
14 checks passed
@mergify mergify Bot deleted the deprecate-query-bar branch May 12, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants