feat(content-sidebar): Add lowercase version number badge variant#4663
Conversation
Gate a lowercase "v{n}" badge behind the new
versions.versionNumberBadge.lowercase.enabled feature flag; the default
uppercase "V{n}" badge is unchanged when the flag is off. Also center
the version sidebar title.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughAdds a feature-flagged lowercase variant ( Lowercase version badge feature flag
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merge Queue Status
This pull request spent 14 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
Description
Gate a lowercase
v{versionNumber}version badge behind a newversions.versionNumberBadge.lowercase.enabledfeature flag. When the flag is off the badge renders the existing uppercaseV{versionNumber}, so default behavior is unchanged. The variant is selected inVersionsItemBadgeviauseFeatureEnabled, backed by a newversionNumberBadgeLowercasei18n message.Also centers the versions sidebar title (
.bcs-titleinVersionsSidebar.scss).Test plan
versions.versionNumberBadge.lowercase.enabledon, the version badge rendersv7(lowercase)V7(uppercase) as beforeyarn test -c scripts/jest/jest.config.js src/elements/content-sidebar/versions/__tests__/VersionsItemBadge.test.jsSemantic release type
feat- New featureSummary by CodeRabbit