-
Notifications
You must be signed in to change notification settings - Fork 350
refactor(select): migrate Select from Flow to TypeScript #4745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bonchevskyi
wants to merge
1
commit into
box:master
Choose a base branch
from
bonchevskyi:refactor/flow-to-ts-select
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
src/components/select/Select.stories.js → src/components/select/Select.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| // @flow | ||
| import * as React from 'react'; | ||
|
|
||
| import Select from './Select'; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| import React, { useState } from 'react'; | ||
| import classNames from 'classnames'; | ||
| import { FormattedMessage } from 'react-intl'; | ||
|
|
||
| import IconInfo from '../../icons/general/IconInfo'; | ||
| import type { Icon } from '../../icons/iconTypes'; | ||
|
|
||
| import { ButtonType } from '../button'; | ||
| import Tooltip, { TooltipPosition, TooltipTheme } from '../tooltip'; | ||
| import Label from '../label'; | ||
| import PlainButton from '../plain-button'; | ||
| import messages from './messages'; | ||
| import './Select.scss'; | ||
|
|
||
| export interface SelectProps extends React.SelectHTMLAttributes<HTMLSelectElement> { | ||
| /** Input `<option />`'s */ | ||
| children?: React.ReactNode; | ||
| /** Custom class name for the select container */ | ||
| className?: string; | ||
| /** Error displayed in a tooltip */ | ||
| error?: React.ReactNode; | ||
| /** Props forwarded to the information icon */ | ||
| infoIconProps?: Partial<Icon> & Record<string, unknown>; | ||
| /** Content displayed in the information tooltip */ | ||
| infoTooltip?: React.ReactNode; | ||
| /** Whether the select is disabled */ | ||
| isDisabled?: boolean; | ||
| /** Label displayed for the input */ | ||
| label: React.ReactNode; | ||
| /** Tooltip displayed for the label */ | ||
| labelTooltip?: string; | ||
| /** Name of the select input */ | ||
| name?: string; | ||
| /** Handler for the change event on the select element */ | ||
| onChange?: React.ChangeEventHandler<HTMLSelectElement>; | ||
| /** Whether to show the error outline without error content */ | ||
| showErrorOutline?: boolean; | ||
| /** Whether to visibly display the label */ | ||
| showLabel?: boolean; | ||
| } | ||
|
|
||
| const Select = ({ | ||
| children, | ||
| className = '', | ||
| error, | ||
| infoTooltip, | ||
| infoIconProps, | ||
| isDisabled, | ||
| label, | ||
| name, | ||
| labelTooltip, | ||
| onChange, | ||
| showErrorOutline = false, | ||
| showLabel = true, | ||
| ...rest | ||
| }: SelectProps) => { | ||
| const classes = classNames(className, 'select-input-container', { | ||
| 'show-error': !!error || showErrorOutline, | ||
| 'is-disabled': isDisabled, | ||
| 'bdl-is-disabled': isDisabled, | ||
| }); | ||
| const [infoTooltipIsOpen, setInfoTooltipIsOpen] = useState(false); | ||
| return ( | ||
| <div className={classes}> | ||
| <Label hideLabel={!showLabel} text={label} tooltip={labelTooltip}> | ||
| <Tooltip | ||
| isShown={!!error} | ||
| position={TooltipPosition.MIDDLE_RIGHT} | ||
| text={error || ''} | ||
|
bonchevskyi marked this conversation as resolved.
|
||
| theme={TooltipTheme.ERROR} | ||
| > | ||
| <span className="select-container"> | ||
| <span className="select-container-inner"> | ||
| {/* eslint-disable-next-line jsx-a11y/no-onchange */} | ||
| <select disabled={isDisabled} name={name} onChange={onChange} {...rest}> | ||
|
bonchevskyi marked this conversation as resolved.
|
||
| {children} | ||
| </select> | ||
|
bonchevskyi marked this conversation as resolved.
|
||
| <span className="select-overlay" /> | ||
| </span> | ||
| {infoTooltip && ( | ||
| <Tooltip | ||
| targetWrapperClassName="tooltip-icon-container" | ||
| isShown={infoTooltipIsOpen} | ||
| position={TooltipPosition.MIDDLE_RIGHT} | ||
| text={infoTooltip} | ||
| > | ||
| <PlainButton | ||
| type={ButtonType.BUTTON} | ||
| onClick={() => setInfoTooltipIsOpen(!infoTooltipIsOpen)} | ||
| > | ||
| <IconInfo | ||
| height={16} | ||
| width={16} | ||
| title={<FormattedMessage {...messages.moreInfo} />} | ||
| {...infoIconProps} | ||
| /> | ||
| </PlainButton> | ||
| </Tooltip> | ||
| )} | ||
| </span> | ||
| </Tooltip> | ||
| </Label> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Select; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export { default } from './Select'; | ||
| export type { SelectProps } from './Select'; |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { defineMessages } from 'react-intl'; | ||
|
|
||
| const messages = defineMessages({ | ||
| moreInfo: { | ||
| defaultMessage: 'More Info', | ||
| description: 'Alt text for info icon', | ||
| id: 'boxui.select.moreInfo', | ||
| }, | ||
| }); | ||
|
|
||
| export default messages; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.