Skip to content
This repository was archived by the owner on Dec 2, 2020. It is now read-only.

Don't Redownload Composer#55

Closed
ivorisoutdoors wants to merge 2 commits intoboxen:masterfrom
ivorisoutdoors:master
Closed

Don't Redownload Composer#55
ivorisoutdoors wants to merge 2 commits intoboxen:masterfrom
ivorisoutdoors:master

Conversation

@ivorisoutdoors
Copy link
Copy Markdown

There's been some really good changes in composer (composer/composer@ac676f4) that make it tons faster then before, but running Boxen will revert composer to before these changes. So instead of forcing a version, just leave composer alone if it's already installed.

Matthew Loberg added 2 commits January 5, 2015 13:40
It's annoying when you update composer and then you run boxen and it
reverts it back to an ealier (slower) version.
@mattheath
Copy link
Copy Markdown
Member

Thanks @mloberg, this looks fine - though we could tighten up the unless condition to use creates as we're only checking for file existence now?

Also might be worth bumping the version to alpha9 so this change is included if the user doesn't have composer already?

@ivorisoutdoors
Copy link
Copy Markdown
Author

It was a quick fix, but creates makes more sense. I'll update it.

With this change though, any users with existing composer installs will
stay at alpha8. One option might be using hiera which would allow a
default, but could also be be overridden by the user.
On Jan 5, 2015 6:35 PM, "Matt Heath" notifications@github.com wrote:

Thanks @mloberg https://github.com/mloberg, this looks fine - though we
could tighten up the unless condition to use creates as we're only
checking for file existence now?

Also might be worth bumping the version to alpha9 so this change is
included if the user doesn't have composer already?

Reply to this email directly or view it on GitHub
#55 (comment).

@mattheath
Copy link
Copy Markdown
Member

Hiera would be ideal, but it would likely be a bit more work to update now. Happy for that to be done separately if someone (you? 😉) wants to pick it up.

@ivorisoutdoors
Copy link
Copy Markdown
Author

I could definitely start some work on it when I have some time.

mattheath added a commit that referenced this pull request Jan 6, 2015
Add manifests for new php versions.
@sambauers
Copy link
Copy Markdown

Hiera for configs is part of the nascent v2.0 plans - #56 - maybe contribute changes to the v2 branch to override composer version and checksum?

@mattheath
Copy link
Copy Markdown
Member

That would be perfect 👍

@sambauers
Copy link
Copy Markdown

I've made an attempt at this via Hiera configs in my existing v2 branch PR. Changeset is here - https://github.com/sambauers/puppet-php/commit/84612e76c1d2424e826814f0333de6acece866d5

@sambauers
Copy link
Copy Markdown

This is covered in the v2 branch now, suggest we close this.

@ivorisoutdoors
Copy link
Copy Markdown
Author

Sounds good to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants