Merged
Conversation
Refactor and simplify the get() function, using some built-in types like http.Header to make the code clearer. Also check for errors when writing to net.Conn. Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
The Headers slice is only ever used for an optional PROXY protocol header, and was easy to confuse with HTTP headers. Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
dswarbrick
force-pushed
the
simplify-get
branch
from
ac01f1c to
3736c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor and simplify the
get()function, using some built-in types likehttp.Headerto make the code clearer. Also check for errors when writing tonet.Conn.Change
Headersstring slice in struct members to aProxyHeaderstring. This is only ever used for an optional PROXY protocol header, and was easy to confuse with HTTP headers.