Animate Code-view active-file dependency links - #99
Conversation
Incident edges pick up the 3D Graph orange/purple particle treatment via SVG dash motion. Inactive edges stay dim; reduced-motion users get a static highlight. Line thickness 1-6 is unchanged. Co-authored-by: Braedon Saunders <braedonsaunders@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Same-color dashes on the orange/purple base were invisible. Beads now use a lighter highlight so the 3D-style motion reads on Code and Graph force edges. Co-authored-by: Braedon Saunders <braedonsaunders@users.noreply.github.com>
Co-authored-by: Braedon Saunders <braedonsaunders@users.noreply.github.com>
Co-authored-by: Braedon Saunders <braedonsaunders@users.noreply.github.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e564975eaa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When prefers-reduced-motion flips on a live page, hide .is-on particles instead of stripping their dash pattern into a solid white overlay. Simulation ticks now skip particle d updates unless a selection is animating, and only rewrite .is-on paths. Co-authored-by: Braedon Saunders <braedonsaunders@users.noreply.github.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 434b431a0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Toggling prefers-reduced-motion now re-runs Code-view link visuals so particles come back after a static selection. Graph selection keeps its prior accent highlight instead of inheriting Code particles. Co-authored-by: Braedon Saunders <braedonsaunders@users.noreply.github.com>
Last leftover from #82: when a file is selected in Code view, its incident dependency edges now move like the 3D Graph
linkDirectionalParticlestreatment.What this does
prefers-reduced-motion: reducekeeps the orange/purple highlight but turns off continuous animation.Helpers (
forceLinkVisual,forceLinkRole,prefersReducedMotion) live in the existing canvas block sotests/code-canvas.test.mjscan cover active vs inactive vs reduced-motion without a DOM.Cards, hulls, minimap, color blocks, root gate, and CLI diff paint are untouched.
Test plan
node --test tests/code-canvas.test.mjs(new helper cases)node --test tests/*.test.mjs tests/*.smoke.jsindex.html, analyze a small fixture, switch to Code, click a card: incident edges move, others stay quiet