Rewrite plex recent as a native button View - #48
Merged
Conversation
Replace the nextcord.ext.menus pagination (RecentlyAddedPageSource + NoStopButtonMenuPages) with a native nextcord.ui.View, matching the modern pattern already used by RandomMediaView. This fixes three issues inherent to the ext.menus button retrofit: - The reaction-wait internal loop disabled the buttons 60s after the message was posted, even during active use; a View resets its timeout on each interaction. - Paging from an item with a poster to one without left the previous poster attached; _show now passes attachments=[] to clear it. - The pagination buttons were drivable by anyone; interaction_check now restricts them to the command author. _show defers the component interaction before fetching the poster so a slow Tautulli image fetch can't blow the 3s ack window, snapshots the index so rapid clicks can't tear the embed, and guards the edit. ext.menus was used nowhere else, so drop NoStopButtonMenuPages from utilities.py and the now-dead nextcord-ext-menus dependency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the nextcord.ext.menus pagination (RecentlyAddedPageSource + NoStopButtonMenuPages) with a native nextcord.ui.View, matching the modern pattern already used by RandomMediaView.
This fixes three issues inherent to the ext.menus button retrofit:
_show defers the component interaction before fetching the poster so a slow Tautulli image fetch can't blow the 3s ack window, snapshots the index so rapid clicks can't tear the embed, and guards the edit.
ext.menus was used nowhere else, so drop NoStopButtonMenuPages from utilities.py and the now-dead nextcord-ext-menus dependency.