[autoconf_pmt] Fix parsing outside PMT descriptors buffer#308
Merged
Conversation
Owner
|
Very good catch ! Thank you very much ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
program_info_lengthspecifies "the number of bytes of the descriptors" but mumudvb unnecessarily increases that value byPMT_LENcausing it to search for a given descriptor outside the descriptors buffer.For example, in my case, the current behaviour is as follows (after adding some custom debugging):
As you can see, the descriptors buffer is assumed to be 23 bytes whereas

program_info_lengthsays it's only 11 bytes. As a result a 3rd, non-existent, descriptor is found (tag: 27) where PMT should have only 2 descriptors (tags: 12 and 14):That 3rd descriptor detected by mumudvb (tag: 27, length: 254) is, in fact, a program element/component with stream type = 27, which you can see in the image above (analysis done by DVBInspector)
After applying my PR the behaviour changes to:
(only 2 descriptors detected)
I've also checked other
pmt_find_descriptorusages and they are all OK - none of them add anything to the buffer length value.