fix -std=c23 build failure#321
Merged
Merged
Conversation
Owner
|
Hello Do you think there is a way to invert the logic so it does work as before unless version is defined and > than xxxx Thank you |
Contributor
Author
I’m not sure on clang and windows. But an alternative that should work on c99 compiles (and does work with gcc-15 is) |
Owner
|
Looks good to me ! |
gcc-15 switched to -std=c23 by default:
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212
As a result `mumudvb` fails the build so only typedef int bool
for __STDC_VERSION__ <= 201710L (C17)
../../src/mumudvb.h:136:47: error: expected ';', identifier or '(' before 'bool'
136 | typedef enum { false = 0, true = !false } bool;
| ^~~~
Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
Contributor
Author
updated and build tested with both gcc-14.2 and gcc-15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcc-15 switched to -std=c23 by default:
As a result
mumudvbfails the build so only typedef int bool for STDC_VERSION <= 201710L (C17)