modules that use spd_pthread_create and module_loop togeather will get multiple definition errors when linking.

[jsett]

Steps to reproduce

You can easily recreate this issue by adding a function for module_debug into dummy.c.

int module_debug(int enable, const char *file)
{
	return 0;
}

The other way you can recreate this bug is by adding spd_pthread_create into one of the skeleton0_ modules.

Obtained behavior

multiple definition errors when linking.

Expected behavior

As spd_pthread_create is a common function it should work in all locations.

spd_pthread_create is necessary to create new threads that play nice with the existing module_loop. module_* functions are need to handle to protocol details.

[sthibaul]

multiple definition errors when linking.

Which multiple definitions do you get exactly?

You can easily recreate this issue by adding a function for module_debug

Well, yes, sure, since it's already defined.

The other way you can recreate this bug is by adding spd_pthread_create into one of the skeleton0_ modules

which right now means including module_utils.c to get MSG, which then indeed provides various functions that you would otherwise have to implement, indeed. For instance, module_loop: either you don't use module_utils.c, and you have to implement it, or you use it, and then you don't have to implement it. Normally it should be fine when using module_utils.c to just use what it provides and not have to implement it yourself.

The matter here is that the existing code is LGPL, which can be incompatible with some other licences, so I introduced enough glue as BSD code to be able to plug any synthesis without using the existing LGPL code from module_utils, the skeleton examples provide an example of that. If you use module_utils, you can drop various functions and just use what it provides. You have an example in src/
modules/skeleton_config.c

Yes, I know, this looks like a mess, I have tempted over the years to please everyone's needs, licensing requirements and whatnot, without breaking anything and without much help from people, the result is not ideal.

As for the actual need here (spd_pthread_create) you can pick it without using module_utils. It just depends on an MSG function. I have now added in #1113 such a function as weak symbol, so you don't have to define one yourself.