Syncing from upstream OCA/storage (17.0)#370
Merged
Merged
Conversation
…t with the specifiation of the type of file binary or base64
For the SSH key a text field is required. The Char field elininates all newline chars making the key invalid.
Previous code used the paramiko client open function with explicit binary mode. But, the explicit binary mode is now ignored by python. See the `open` function description into the paramiko documentation: https://docs.paramiko.org/en/stable/api/sftp.html ``` The Python 'b' flag is ignored, since SSH treats all files as binary. ``` But in fact, depending of the SFTP server we have an `OSError`. Then this PR remove the useless binary mode, and avoid to have errors.
Currently translated at 100.0% (13 of 13 strings) Translation: storage-16.0/storage-16.0-storage_backend_sftp Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-storage_backend_sftp/it/
There's no need to depend on the additional lib mock.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 17.0 #370 +/- ##
==========================================
- Coverage 90.11% 90.00% -0.12%
==========================================
Files 104 111 +7
Lines 3815 3991 +176
Branches 358 363 +5
==========================================
+ Hits 3438 3592 +154
- Misses 263 284 +21
- Partials 114 115 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt_gitbot