libftdi: handle ftdi_new failing - #228
Merged
Andrey1994 merged 1 commit intoFeb 11, 2021
Merged
Conversation
Contributor
Author
|
Note: I'm learning the insides of libftdi a little, and it looks like a cleaner solution to this would be to use ftdi_init/ftdi_deinit instead of ftdi_new/ftdi_free. This preserves libftdi's internal error messages when initialisation fails, and also saves a minor heap allocation. |
Member
|
Since I already merged it lets do it in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds code to handle the edge case of ftdi_new returning 0, which happens when libusb_init fails.