Fix Type#deserialize to handle arrays for multiple: true attributes#473
Merged
nashby merged 1 commit intobrainspec:masterfrom Jan 27, 2026
Merged
Conversation
Previously, deserializing an array would return nil instead of the enumerated values. This bug only affected ActiveModel::Attributes usage (not ActiveRecord) and was exposed when used with gems like store_model v2.0.0+ that call deserialize during load. The fix checks if the value is an array AND the attribute is declared with multiple: true, then uses find_values(*value) instead of find_value(value). Added 10 test cases covering: - Single value deserialization (existing behavior) - Array deserialization for multiple: true attributes - Array rejection for non-multiple attributes - Empty arrays, nil handling, and invalid value filtering - Round-trip serialization for both single and multiple values
Member
|
@segiddins thank you! |
Contributor
Author
|
@nashby thanks for merging! any chance I can ask you to cut a release when you have the time? thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, deserializing an array would return nil instead of the enumerated values. This bug only affected ActiveModel::Attributes usage (not ActiveRecord) and was exposed when used with gems like store_model v2.0.0+ that call deserialize during load.
The fix checks if the value is an array AND the attribute is declared with multiple: true, then uses find_values(*value) instead of find_value(value).
Added 10 test cases covering: