fix(release): consistent nodemailer tree for electron-builder + fail-fast matrix#111
Merged
Merged
Conversation
…fast matrix The v0.1.9 build died in electron-builder's bun node-module collector: the root `overrides: nodemailer ^9` (dependabot audit, #106) made imapflow's declared nodemailer@8.0.10 resolve elsewhere, and the traversal collector hard-fails on a declared-but-not-found production dep. Fix at the source: imapflow ^1.4.6 + mailparser ^3.9.14 both declare nodemailer 9.0.3 natively, so the override is gone and every copy in the tree is 9.0.3 (the stale @types/imapflow-scoped 1.4.0 lockfile entry pruned too). Proven with a local `electron-builder --mac --dir` dry-run — the exact step that failed. Also: release matrix flips to fail-fast: true — a broken release build should stop all legs in minutes, not keep three runners burning. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the v0.1.9 release. Two changes:
overrides: nodemailer ^9(from the Dependabot audit) created for imapflow'snodemailer@8.0.10. Root-cause fix: bumpimapflow ^1.4.6+mailparser ^3.9.14(both declare nodemailer 9.0.3 natively) and drop the override — every nodemailer in the tree is now 9.0.3 with consistent declarations. Verified with a localelectron-builder --mac --dirdry-run (exit 0 — the exact step that failed in CI); mailbox worker tests green (42/42).Process note:
verify/testnever exercise packaging, so dep-graph changes could break only at release time — the--dirdry-run is the missing gate; I'll remember to run it for future dependency PRs.After merge: I re-point the v0.1.9 tag at the fixed main and re-fire the release.
🤖 Generated with Claude Code